buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Refactor queue creation and attribute handling #100

Open ashkankamyab opened 1 year ago

ashkankamyab commented 1 year ago

This commit introduces changes to the Create method of the Queue struct, improving the flexibility and configurability of queue attributes. The following updates were made:

These changes improve the modularity and adaptability of the code, allowing for easier customization of queue policies and attribute configurations. They provide a more seamless integration with environment variables, offering greater flexibility in different deployment scenarios.

These modifications enhance the maintainability and configurability of the codebase, ensuring a more robust and adaptable queue management solution.

ashkankamyab commented 1 year ago

Sorry I pushed the wrong commit

DrJosh9000 commented 1 year ago

Hi @ashkankamyab, sorry for the slow response.

We had a look and have two main suggestions:

Please let us know how much of a blocker this is for you, so we can give the right amount of help to get this merged!

ashkankamyab commented 1 year ago

Hi Sorry for delay. I was stucked in my daily tasks. I will fix it asap :-)