search

buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Add support for logging to a file (prerequisite for CloudWatch logging). #32

Closed itsdalmo closed 6 years ago

itsdalmo commented 6 years ago

In order to support CloudWatch logging, this PR allows us to write to a log file in addition to outputting to journalctl. The benefit of which is that we don't have to write a systemd unit just for tailing the journalctl logs and passing them to a file in order for the awslogs agent to send them to CloudWatch.

It's an optional parameter since not everyone is necessarily running on systemd (or want this).

lox commented 6 years ago

Might it just be better to log directly to cloudwatch logs with something like https://github.com/kdar/logrus-cloudwatchlogs?

lox commented 6 years ago

Thoughts on https://github.com/buildkite/lifecycled/pull/38 as an alternative @itsdalmo?

itsdalmo commented 6 years ago

Closing in favor of #38 👍