buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Rewrite as lifecycle and spot monitors #44

Closed lox closed 6 years ago

lox commented 6 years ago

Thinking about #42 prompted me to try more elegantly splitting the spot and lifecycle monitoring into dedicated objects and leaving the Daemon entirely focused on process management.

This cleans up the SQS queue as soon as the lifecycle handler script has completed successfully, which seems about as quick as is possible.

Thoughts @itsdalmo?

itsdalmo commented 6 years ago

This is great stuff, really like the Monitor concept 👍

Some comments:

I think perhaps a combination of this and what I suggested in #42 could be neat?

lox commented 6 years ago

I made some of the changes you suggested, and drew some inspiration from #42. Lemme know what you think @itsdalmo.