Closed lox closed 6 years ago
This is great stuff, really like the Monitor
concept 👍
Some comments:
Monitor
in it's name 🤔 daemon
will continue to run until both the LifecycleMonitor
and SpotMonitor
return, but really lifecycled
should exit with an error if e.g. a queue is supplied but fails to create?I think perhaps a combination of this and what I suggested in #42 could be neat?
I made some of the changes you suggested, and drew some inspiration from #42. Lemme know what you think @itsdalmo.
Thinking about #42 prompted me to try more elegantly splitting the spot and lifecycle monitoring into dedicated objects and leaving the
Daemon
entirely focused on process management.This cleans up the SQS queue as soon as the lifecycle handler script has completed successfully, which seems about as quick as is possible.
Thoughts @itsdalmo?