buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

New release (3.0?) #53

Closed itsdalmo closed 6 years ago

itsdalmo commented 6 years ago

I think we might be ready for a new release since merging the following PRs:

Perhaps a 3.0, since technically, the public interface has changed with the addition of a --spot flag? Thoughts @lox?

lox commented 6 years ago

Yeah, I was going to do a bit of testing and get #49 merged and then put out a 3.0!

itsdalmo commented 6 years ago

Have you had a chance to do any tests @lox?

I ask because I'm working on a deployment using lifecycled v2.1.1 (Concourse), and dangling queues are troubling me. The current version does not clean up the queue if the handler script exits with an error, since complete() is never reached in this case.

lox commented 6 years ago

Hmmmm. I haven't, apologies. I'll prioritize it if it's still an issue in the 2.x series.

lox commented 6 years ago

Ok, I did some testing today. I reckon we should have spot enabled by default and add a --no-spot flag to opt out. Thoughts @itsdalmo?

itsdalmo commented 6 years ago

Roger that! I don't use lifecycled with spot instances myself since the handler can take more >2min to execute, but for backwards compatibility it makes sense to inverse the logic - I'll submit a PR 👍

itsdalmo commented 6 years ago

@lox - are you still testing the current master branch?

lox commented 6 years ago

Sorry, I finished testing, everything looks good. Let's put out a release!

itsdalmo commented 6 years ago

Awesome, thanks!