buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Move to golang 1.11 #57

Closed lox closed 5 years ago

itsdalmo commented 6 years ago

Loving it! I have not used go mods myself yet, but is not using a vendor folder the recommended practice now? In the past the rule of thumb I've heard has been that libraries should not use a vendor folder, while binaries should vendor?

lox commented 6 years ago

@itsdalmo yeah, the go team basically recommends not vendoring with modules. When modules are active vendor/ is ignored.

toolmantim commented 6 years ago
image

😱

lox commented 5 years ago

Closing in favour of #59.