buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Cross compile for all archs supported by gox #68

Closed tduffield closed 5 years ago

tduffield commented 5 years ago

This is mostly here to start a conversation.

We are trying to set up Buildkite pipelines on some archs that are supported by the buildkite agent, but do not currently have a lifecycled build. To proceed we've had to build and host our own, but I wanted to have the conversation about making it "official"

tduffield commented 5 years ago

At the very least, would you consider adding the following: linux/386, freebsd/amd64, and linux/arm64?

lox commented 5 years ago

Would be happy to provide any archs that folks need @tduffield!

lox commented 5 years ago

I think I'd prefer to just add the above first @tduffield!

tduffield commented 5 years ago

@lox okay! I had to do some shenanigans since gox doesn't build arm for some reason, but here you go. I also made sure to name the arm64 build with both the arm64 and aarch64 architecture tags.

lox commented 5 years ago

Might be a good point to swap to https://github.com/buildkite-plugins/golang-cross-compile-buildkite-plugin? Happy to merge this as is though.

tduffield commented 5 years ago

@lox Happy to do that as a second iteration. Would love to have at least one set of builds I can reference so I can unblock myself. I'm new(er) to Golang so it might take me a bit to reason about the end-to-end build process.

tduffield commented 5 years ago

@lox Hey, sorry if there was any confusion on my last message. Can we merge this as is and work on the plugin in a second PR?

lox commented 5 years ago

I'll get a release out with the new archs.