buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Feature request: accept launching events #79

Open qrilka opened 5 years ago

qrilka commented 5 years ago

Currently lifecycled supports only termination events. Is there any problem with supporting instance launching events? Of course some actions could be done on instance launch by using user_data of a launch configuration but the end result isn't the same like the case when handlers (both for instance launches and terminations) could be run on 1 dedicated host outside of a monitored ASG.

lox commented 5 years ago

I don't see why not! Would happily accept a PR.

borsboom commented 5 years ago

Without #80, I can't think of how this would make sense. Launch events happen before the instance launches, which means lifecycled wouldn't actually be running yet in order to receive the event. Together with #80 it would make perfect sense though.