search

buildkite / lifecycled

A daemon for responding to AWS AutoScaling Lifecycle Hooks
MIT License
146 stars 34 forks source link

Outdated AWS SDK #86

Closed asiragusa closed 3 years ago

asiragusa commented 4 years ago

The current AWS SDK (v1.15.68) does not support IMDS v2 https://aws.amazon.com/blogs/security/defense-in-depth-open-firewalls-reverse-proxies-ssrf-vulnerabilities-ec2-instance-metadata-service/

A go get -u github.com/aws/aws-sdk-go will fixes the issue, I have tested with a local build.

ketzacoatl commented 4 years ago

AWS SDK (v1.15.68)

Yikes, that's quite old, from Oct/Nov 2018 it seems:

image

(https://github.com/aws/aws-sdk-go/commit/b20851c3cbaede4743ba0672171623986539f0b4#diff-fe3b36d57dc4378fa7b13c85492f4119)

Is there a version pin in the code we can update for CI to run the build? Or is the release driven by @lox? How do we get this update applied?

lox commented 3 years ago

Closed via #88