search

buildkite / pipeline-schema

A JSON schema for Buildkite’s pipeline file format
MIT License
31 stars 35 forks source link

Add `depends_on` and `key` to group step definitions #28

Closed svvitale closed 2 years ago

svvitale commented 2 years ago

These options are valid and listed in the BuildKite documentation: https://buildkite.com/docs/pipelines/group-step#group-step-attributes

Fixes #27

stevebarreira commented 2 years ago

According to the doc it seems the groupStep.steps should also include the wait commands as valid values:

        "steps": {
          "type": "array",
          "description": "A list of steps",
          "items": {
            "anyOf": [
              { "$ref": "#/definitions/stringBlockStep" },
              { "$ref": "#/definitions/commandStep" },
              { "$ref": "#/definitions/nestedCommandStep" },
              { "$ref": "#/definitions/triggerStep" },
              { "$ref": "#/definitions/nestedTriggerStep" },
              { "$ref": "#/definitions/stringWaitStep" },
              { "$ref": "#/definitions/waitStep" }
            ]
          },
svvitale commented 2 years ago

Added these + relevant tests.

eleanorakh commented 2 years ago

Thanks so much @svvitale, and apologies for the delay in getting back to you! This looks great, I'm going to merge it in. Let me know how you go with it 🙏🏻