search

buildkite / pipeline-schema

A JSON schema for Buildkite’s pipeline file format
MIT License
30 stars 34 forks source link

Add cancel_on_build_failing property for commnad step definition #47

Closed amishra-u closed 1 year ago

amishra-u commented 1 year ago

Buildkite added new attribute called cancel_on_build_failing. Added cancel_on_build_failing attribute to buildkite schema.

jamison-lahman-ai commented 1 year ago

Closes https://github.com/buildkite/pipeline-schema/issues/48

timriley commented 1 year ago

Closing this in favour of #49; we'll be addressing that PR shortly. Thanks again and sorry to keep you waiting here!

jamison-lahman-ai commented 1 year ago

@timriley I think this also intended to close https://github.com/buildkite/pipeline-schema/issues/37 which is missing from #49. Happy to send a patch to solely address https://github.com/buildkite/pipeline-schema/issues/37 as I am also interested in that change (though I suspect will just be this delta once that lands in main)

mhaylock commented 1 year ago

Thanks @jl-applied, we've merged #45 today which fixes #37 - I've closed that issue now, thanks for pointing it out.

jamison-lahman-ai commented 1 year ago

Got it. Thanks all :+1: