buildkite / sockguard

A proxy for docker.sock that enforces access control and isolated privileges
MIT License
143 stars 22 forks source link

handleContainerCreate Test Coverage #30

Closed CpuID closed 6 years ago

CpuID commented 6 years ago

Specifically around container create to start.

Pretty non-trivial IMO, covers most feature flags, uses fixtures for HTTP request inputs and validates the outputs.

I plan to do some of the other resource creation types next (networks, etc), in preparation for some more controversial feature suggestions (which I want coverage around before I do) :)

cc @lox

lox commented 6 years ago

Nice one @CpuID