buildkite / sockguard

A proxy for docker.sock that enforces access control and isolated privileges
MIT License
143 stars 22 forks source link

fix: check volume ownership when binding #47

Closed jirislav closed 5 years ago

jirislav commented 6 years ago

It was possible to bind any volume which didn't belong to the user, because there was not performed the ownership check while binding.

This PR implements checking for volume ownership when binding.

For more information about why it is bad to allow mounting any volume, see #46.

lox commented 5 years ago

Thanks, great find and fix.