search

buildkite / templates

Buildkite pipeline templates
https://buildkite.com/pipelines/templates
MIT License
2 stars 1 forks source link

Lacework template #116

Closed clbarrell closed 3 months ago

clbarrell commented 3 months ago

This is for customers who want to use Lacework in their pipelines, using the Lacework Buildkite Plugin.

This template makes use of the Lacework Buildkite Plugin to run Laceworks CLI and perform Software Composition Analysis (and more)

Link to issue https://github.com/buildkite/templates/issues/115

@jeremybumsted to review confirm

mbelton-buildkite commented 3 months ago

Subscribing for updates! I'm working on the launch blog and might include this template if it's ready 😊

jeremybumsted commented 3 months ago

@dannymidnight I've added the requested changes and updated some pieces that coincides with some incoming changes to the plugin.

mbelton-buildkite commented 3 months ago

I see this only uses the SCA functionality in the plugin. Lacework are making updates to also support SAST, IaC scanning, and container scanning. Should they be included in this template?

jeremybumsted commented 3 months ago

I see this only uses the SCA functionality in the plugin. Lacework are making updates to also support SAST, IaC scanning, and container scanning. Should they be included in this template?

@mbelton-buildkite I've included a blurb in the template about other features and that folks should check out the plugin to see all the options. Do we want to include more in a single template (It would become multiple steps, but I'm not sure how simple/complex we want these to be) Happy to include more in another PR though!

jeremybumsted commented 3 months ago

@clbarrell @dannymidnight I think this is good to merge - only question I have is do we want to include the other examples of plugin functionality in the same template, or create separate templates? Also, the build seems to keep failing for some reason and I've got no visibility as to why unfortunately.

clbarrell commented 3 months ago

Ship it! 🚀

I'm not familiar with that other functionality, so take this with a grain of salt. Generally, we're happy with more templates as long as they are somewhat independent. If the other functionality that we have just worked on is distinct enough to consider it a different feature, then yes, keep the templates separate. For example, if this template is about vulnerability scanning, and the other ones are about software composition, then definitely create a separate template with a distinct name.

dannymidnight commented 3 months ago

think this is good to merge - only question I have is do we want to include the other examples of plugin functionality in the same template, or create separate templates? Also, the build seems to keep failing for some reason and I've got no visibility as to why unfortunately.

I've granted you access to the pipeline so you should be able to see those failures in the future.

In this instance, it looks like you're just missing some frontmatter.

Errors found:
--
  | Template lacework/README.md has errors: missing platforms

I can update and get this one merged for you.