search

buildkite / templates

Buildkite pipeline templates
https://buildkite.com/pipelines/templates
MIT License
2 stars 1 forks source link

Building an npm package #21

Closed clbarrell closed 5 months ago

clbarrell commented 9 months ago

Generated a pipeline and readme for a pipeline that uses docker-compose to do CI/CD for a react UI library.

Inspired by an open source library.

To be verified and edited.

dannymidnight commented 9 months ago

A few thoughts on this one.

Using docker-compose is a tricky one since it requires a docker-compose.yml file with services that match up. I wonder if as a general rule we should preference the docker-plugin over the docker-compose-plugin. Alternatively, do we skip docker altogether as we've spoken about in the past?

There's nothing inherently React about this particular pipeline. I wonder if this instead becomes our publish an npm package pipeline?

Also yarn vs. npm? I think I'd stick with with npm.

dannymidnight commented 9 months ago

If we did want to make this more about React then I'd make the pipeline incorporate something like Storybook, Percy, or Browserstack for visual regression testing.

clbarrell commented 9 months ago

Changed this to being just building an npm package.

though - seeing how the Docker stuff worked is pretty useful,might make another just for that of building and reusing an image

dannymidnight commented 5 months ago

I'm going to say https://github.com/buildkite/templates/pull/99 now supersedes this PR.

There is still a use-case for publishing direct to the NPM registry, which perhaps is what this PR could become. For now, I'm going to close this one.