Closed byroot closed 8 years ago
I reckon we could make this happen! I think if we tweaked the URL colour to use: color: currentColor
instead of a new URL colour, then I think it would work?
hmmm. This feels more like a stylesheet change outside of terminal - remove the colour override on links within the rendered terminal section.
@byroot could you DM me a link to a build with a link in it so I can tweak da css?
Indeed. I just tested and all it needs is color: inherit;
on these links.
Ref: https://github.com/buildkite/terminal/issues/29
So I tried to use the new links, but unfortunately my plan was to use it to improve our test failure backtraces with links to GitHub. Ultimately it would work, but I'm not willing to lose the backtrace colorization I put in place:
Not sure what the best syntax would be to chose the link color. Ideally I could use regular ANSI color code in it:
But here's what it gives me right now
@keithpitt @toolmantim @mipearson do you guys think it makes sense or am I pushing it?