search

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML
http://buildkite.github.io/terminal-to-html
MIT License
649 stars 45 forks source link

Allow to colorize links #31

Closed byroot closed 8 years ago

byroot commented 8 years ago

Ref: https://github.com/buildkite/terminal/issues/29

So I tried to use the new links, but unfortunately my plan was to use it to improve our test failure backtraces with links to GitHub. Ultimately it would work, but I'm not willing to lose the backtrace colorization I put in place:

capture d ecran 2015-11-26 a 13 37 59

Not sure what the best syntax would be to chose the link color. Ideally I could use regular ANSI color code in it:

echo -e '\033]1339;url=https://google.com/;content=\033[33mHello World\033[0m\a'

But here's what it gives me right now

capture d ecran 2015-11-26 a 13 41 44

@keithpitt @toolmantim @mipearson do you guys think it makes sense or am I pushing it?

keithpitt commented 8 years ago

I reckon we could make this happen! I think if we tweaked the URL colour to use: color: currentColor instead of a new URL colour, then I think it would work?

mipearson commented 8 years ago

hmmm. This feels more like a stylesheet change outside of terminal - remove the colour override on links within the rendered terminal section.

keithpitt commented 8 years ago

@byroot could you DM me a link to a build with a link in it so I can tweak da css?

byroot commented 8 years ago

Indeed. I just tested and all it needs is color: inherit; on these links.