search

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML
http://buildkite.github.io/terminal-to-html
MIT License
649 stars 45 forks source link

Allow to specify `target` attribute in links #32

Open byroot opened 8 years ago

byroot commented 8 years ago

Ref: #29 So the link feature is awesome:

bk-links

One little downside: I wish I could specify target="_blank" because output pages are quite big and take a while to load, so it's a bummer when you forget to open the link in a new tab and that you have to load the output page again after.

@toolmantim @keithpitt @mipearson what do you think?

I tried to implement it myself, but my go is really not good :/

keithpitt commented 8 years ago

We could probably make it an boolean in the sequence? I think it's a valid case to be able to open it in a new tab.

keithpitt commented 8 years ago

Also, how do you do the linking? Is it something you'd be able to open source? :D:D

byroot commented 8 years ago

Also, how do you do the linking? Is it something you'd be able to open source? :D:D

In part maybe. But it's quite dirty / coupled to our application ATM.

keithpitt commented 7 years ago

What do you think of this @mipearson?

ticky commented 7 years ago

The only thing I’d suggest is we be wary of the fact that this has potential security considerations (especially considering this is linking to user-specified content), albeit ones Google don’t seem too concerned about

mipearson commented 7 years ago

I think a solution for this is that we add target="_blank" to the links rather than a custom thing