Ineffective comparison in (*style).isEqual

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML

http://buildkite.github.io/terminal-to-html

MIT License

649 stars 45 forks source link

Closed dominikh closed 8 years ago

dominikh commented 8 years ago

In the following line of code s.otherColors == s.otherColors should read s.otherColors == o.otherColors

return s == o || (s.fgColor == o.fgColor && s.bgColor == o.bgColor && s.otherColors == s.otherColors)

/src/github.com/buildkite/terminal/style.go:16:72: identical expressions on the left and right side of the '==' operator

toolmantim commented 8 years ago

Thanks for the catch!