Closed keithpitt closed 7 years ago
Thanks @keithpitt!
@keithpitt I'm tempted to have a go at this - do you have a failing automated test case already?
@mipearson oh hai! I wasn't expecting you to have a crack, but I'll make a PR with a failing test case now.
No promises, but I really really really miss hacking on Go, so if I get some time I'll have a crack.
@mipearson added a failing test case here: https://github.com/buildkite/terminal/pull/40
Attached is a sample log output from a
docker pull
command.sample.txt
When you run
cat sample.txt
you see this:When you run it through terminal, you get:
Something weird is going on, and I believe I've tracked it down to our
up
handling. Specifically ourA
instruction here:Now during my testing, if I added this 1 line:
The problem went away. I don't think the adding of the character is fixing the issue, but when we
append
a ton of other internal other stuff takes place:I spent half a day on this on Friday, and got sucked into a wormhole. The hard thing is not knowing what the correct behaviour is in a shell. So I'll need to pair with someone this week (probably @sj26) and get it fixed up.