Ignore unsupported element sequences

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML

http://buildkite.github.io/terminal-to-html

MIT License

649 stars 45 forks source link

Closed c960657 closed 6 years ago

c960657 commented 7 years ago

If terminal-to-html encounters an unsupported element sequences such as ESC ]2;foobar ^G (set window title), it outputs an error message.

The Apple Terminal and iTerm2 simply ignores unknown sequences. This patch makes terminal-to-html do the same.

c960657 commented 6 years ago

Ping? I miss this change on Buildkite.com.

ticky commented 6 years ago

Hi @c960657, sorry we didn’t get to this until now. Thanks for the contribution!

ticky commented 6 years ago

Just shipped this release, and it’s on prod now. Thanks again!