Fixes issue with terminals wider than 127 characters.

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML

http://buildkite.github.io/terminal-to-html

MIT License

658 stars 44 forks source link

Fixes issue with terminals wider than 127 characters. #67

Closed wasv closed 3 years ago

wasv commented 4 years ago

Replaces ParseInt with ParseUint within pi() helper function.

ticky commented 4 years ago

I haven’t been able to reproduce this issue, even with very large terminal windows and very long outputs, is there a test case you could provide?

wasv commented 4 years ago

I forget what it was that I was trying to fix with this. I recall having issues with characters after the 127th wrapping around, and overwriting the beginning of the line, but I don't know what context that was in.

ticky commented 3 years ago

Hi @wasv, if you could find a way to reproduce this error I'd love to hear what it is, for now though I'm going to close this as I haven't been able to reproduce the issue. Thanks for the contributions, though!