search

buildkite / terminal-to-html

Converts arbitrary shell output (with ANSI) into beautifully rendered HTML
http://buildkite.github.io/terminal-to-html
MIT License
661 stars 44 forks source link

Updates Dockerfile to to golang 1.12 #81

Closed wasv closed 4 years ago

wasv commented 4 years ago

In the process of testing #68, I was unable to build the code in a Go 1.9 docker image. I was able to build after updating the Go image version to 1.12 in the Dockerfile and adding GO111MODULE=on as an environment variable.

This PR changes the Go image version to 1.12 and adds GO111MODULE=on to the environment variables. This fixes #80.

It may be worth noting that I was using podman instead of docker, however I don't think that would cause this issue.

yob commented 4 years ago

I confirmed this issue exists in standard docker as well, and this change resolves it.

on master:

root@9970873adc12:/go/src/github.com/buildkite/terminal-to-html# cd cmd/terminal-to-html/
root@9970873adc12:/go/src/github.com/buildkite/terminal-to-html/cmd/terminal-to-html# go build .
terminal-to-html.go:12:2: cannot find package "github.com/buildkite/terminal-to-html/v3" in any of:
        /usr/local/go/src/github.com/buildkite/terminal-to-html/v3 (from $GOROOT)
        /go/src/github.com/buildkite/terminal-to-html/v3 (from $GOPATH)
terminal-to-html.go:13:2: cannot find package "github.com/urfave/cli" in any of:
        /usr/local/go/src/github.com/urfave/cli (from $GOROOT)
        /go/src/github.com/urfave/cli (from $GOPATH)

on this pr:

root@bef2d578b4b6:/go/src/github.com/buildkite/terminal-to-html/cmd/terminal-to-html# go build .
go: downloading github.com/urfave/cli v1.22.4                          
go: extracting github.com/urfave/cli v1.22.4
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d
go: extracting github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d
go: downloading github.com/russross/blackfriday/v2 v2.0.1                                                                                     
go: extracting github.com/russross/blackfriday/v2 v2.0.1                                                                                      
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0                                                                              
go: extracting github.com/shurcooL/sanitized_anchor_name v1.0.0                                                                               
root@bef2d578b4b6:/go/src/github.com/buildkite/terminal-to-html/cmd/terminal-to-html# exit

Thanks!