Closed jasmine-q closed 1 year ago
This looks good to me, except that the new tests are failing on Python 3.8 - any idea why?
Sorry I have no idea @jimsynz, I'm not too familiar with python myself. I've reached out to a couple people at Buildkite who are more familiar with python for their thoughts.
I've done some digging into this. From what I can see the code is working correctly, but pytest using python 3.8 is not capturing stderr. Only stdout is captured. I'm not sure why.
Ship it :)
Linear ticket: https://linear.app/buildkite/issue/PIE-1486/python-collector-shouldnt-fail-customer-builds
There was an incident affecting the main database, and as a result TA was timing out. The TA timeouts then caused a customer's builds to break which is bad.
Changes:
submit
so we don't fail builds if there is aReadTimeout
or aConnectTimeout
Future plans:
ReadTimeout
andConnectTimeout