buildkite / test-collector-python

Python adapter for Buildkite Test Analytics
https://buildkite.com/test-analytics
MIT License
6 stars 5 forks source link

[PIE-1486] python collector shouldn't fail customer builds #17

Closed jasmine-q closed 1 year ago

jasmine-q commented 1 year ago

Linear ticket: https://linear.app/buildkite/issue/PIE-1486/python-collector-shouldnt-fail-customer-builds

There was an incident affecting the main database, and as a result TA was timing out. The TA timeouts then caused a customer's builds to break which is bad.

Changes:

Future plans:

jasmine-q commented 1 year ago

This looks good to me, except that the new tests are failing on Python 3.8 - any idea why?

Sorry I have no idea @jimsynz, I'm not too familiar with python myself. I've reached out to a couple people at Buildkite who are more familiar with python for their thoughts.

swebb commented 1 year ago

I've done some digging into this. From what I can see the code is working correctly, but pytest using python 3.8 is not capturing stderr. Only stdout is captured. I'm not sure why.

jimsynz commented 1 year ago

sure

Ship it :)