search

buildkite / test-collector-python

Python adapter for Buildkite Test Analytics
https://buildkite.com/test-analytics
MIT License
6 stars 5 forks source link

typing.Literal requires python 3.8 #5

Closed tigris closed 2 years ago

tigris commented 2 years ago

It seems some code here is relying on typing.Literal.

However, according to python docs, this type was only introduced in python 3.8, making this library unusable on python 3.7.

I don't see anything in the README.md specifying a minimum python version, nor does the setup.py use the python_requires to specify one. I'm unsure if the team have decided on a minimum version or not. Python 3.7 is officially supported until 27 Jun 2023, which is not that far away, so perhaps customers should just upgrade to 3.8. Still be good to document this somewhere.

jasmine-q commented 2 years ago

Hi @tigris, thanks for your feedback. I'm on the Test Analytics team but I am unfortunately not too familiar with python, so I would really appreciate if you could review my PR https://github.com/buildkite/test-collector-python/pull/6

jasmine-q commented 2 years ago

New release resolves the issue https://github.com/buildkite/test-collector-python/releases/tag/v0.1.2