Time for the ol' ruby test collector to get a 💇♀️
I've removed three things:
All the code that established the websocket connection, and the session that managed sending data through the websocket
Debug mode - basically the only thing that we used the logging for was for the socket session because it was so complicated. There isn't really anything to log anymore. Hence I have removed it. Note that this is a breaking change to the Buildkite::TestCollector.configure method, so this line in bk/bk's spec_helper will need to be removed. I don't anticipate breaking any customer config with this, as we don't advertise configuring the debug mode like that, but instead nudge them to use the env variable.
.safe method - we had this method as a catch all because the socket functionality used to throw random exceptions that we weren't expecting and weren't handling. This doesn't happen anymore, and this function isn't used anymore.
I've tested this PR with running an rspec test and minitest test. Note that if you are testing this change locally, you'll also need to change the config in spec helper.
Time for the ol' ruby test collector to get a 💇♀️
I've removed three things:
Buildkite::TestCollector.configuremethod, so this line in bk/bk's spec_helper will need to be removed. I don't anticipate breaking any customer config with this, as we don't advertise configuring the debug mode like that, but instead nudge them to use the env variable..safemethod - we had this method as a catch all because the socket functionality used to throw random exceptions that we weren't expecting and weren't handling. This doesn't happen anymore, and this function isn't used anymore.I've tested this PR with running an rspec test and minitest test. Note that if you are testing this change locally, you'll also need to change the config in spec helper.