search

buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
15 stars 26 forks source link

Safeguard SecureRandom.uuid #187

Closed ChrisBr closed 1 year ago

ChrisBr commented 1 year ago

This is a follow up to https://github.com/buildkite/test-collector-ruby/issues/131.

Our test suite stubs SecureRandom.uuid in various places so enabling [test-collector-ruby](https://github.com/buildkite/test-collector-ruby) breaks our test suite.

We thought this was fixed with https://github.com/buildkite/test-collector-ruby/pull/133 but we still see this happening.

I believe the best approach is to just safe guard SecureRandom.uuid by storing a private reference to the method.

blaknite commented 1 year ago

Closed in favour of #192