search

buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
16 stars 25 forks source link

Capitalize safeguarded UUID class #189

Closed blaknite closed 1 year ago

blaknite commented 1 year ago

This builds upon #187 by conforming to our preference to upcase acronyms and fixing some tests.

From the original PR:

This is a follow up to https://github.com/buildkite/test-collector-ruby/issues/131.

Our test suite stubs SecureRandom.uuid in various places so enabling test-collector-ruby breaks our test suite.

We thought this was fixed with https://github.com/buildkite/test-collector-ruby/pull/133 but we still see this happening.

I believe the best approach is to just safe guard SecureRandom.uuid by storing a private reference to the method.

blaknite commented 1 year ago

Looks good, has this been integration tested against a local bk/bk?

Not yet!

blaknite commented 1 year ago

Closed in favour of #192