search

buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
16 stars 25 forks source link

Stop sending execution id #192

Closed niceking closed 1 year ago

niceking commented 1 year ago

Builds upon #189 and #187

We've decided to stop generating execution IDs client side. However, that wasn't the only place the ruby test collector was using SecureRandom.uuid, so am also still including the patch that @ChrisBr submitted that @blaknite then added to

Has been integration test against bk/bk

There'll be a follow up PR on bk/bk that also ignores any execution IDs that are sent from test collector clients but this PR can be merged and released independently of that

jasmine-q commented 1 year ago

makes sense to my not a ruby expert eyes 👀 will defer deeper diving to other rubyists