search

buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
15 stars 26 forks source link

Gem isn't ruby 2.3 compatible #199

Closed alagos closed 1 year ago

alagos commented 1 year ago

That's what is defined in the gemspec, but it has ruby 2.6 syntax like this which makes the gem to fail in older versions (ruby 2.4 in my case), so it should be updated the gemspec or change that syntax to make it compatible with older ruby versions.

gchan commented 1 year ago

Hi @alagos , it sounds like your preference is for Ruby 2.4 to remain supported (let me know otherwise!).

I'll check with the team to see whether EOL Ruby versions should continue to be supported.

alagos commented 1 year ago

Well, if ruby 2.4 can be supported, that would be awesome. We're still in the process to upgrade to supported ruby versions, but in the meantime would be nice to have access to this gem.

gchan commented 1 year ago

Hi @alagos , I'm working on restoring comparability for Ruby 2.3 over at #201 , let me know if you have any feedback or comments!

Support for Ruby 2.4 will not be permanent and we will likely have a plan to gradually drop support for older versions of Ruby.

How long do you think your team requires Ruby 2.4 support?

alagos commented 1 year ago

@gchan wow, that's great. We're in the process to upgrade our stack (a year ago we were with ruby 2.2), so hopefully a year from now.

gchan commented 1 year ago

Hi @alagos , we've published a new version of the gem which supports Ruby versions 2.3 and above.

https://github.com/buildkite/test-collector-ruby/releases/tag/v2.3.2

Please note support for EOL'ed versions of Ruby may be removed in the future.

alagos commented 1 year ago

Sure, I'll keep in mind. Thanks for all