buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
16 stars 25 forks source link

[PIE-2044] Output a summary of TA links in rspec log #207

Closed meghan-kradolfer closed 1 year ago

meghan-kradolfer commented 1 year ago

Description

Output test analytics links within the summary of an rspec run. Using the rspec dump_failures method we can output a list of all the failed examples within a run.

Links will only output links if:

The test link url is created by getting the suite_url from the from the metadata endpoint within BK, the suite_url is currently only populated when the feature flag analytics_job_log_test_links is turned on, when the flag is off the dump_failures will return empty and not output will appear. The suite_url is then appended with the scope_name_digest as the test identifier

https://github.com/buildkite/test-collector-ruby/assets/25017977/b757cf16-daf2-48c7-9a30-f4dd5c91fe18

Context

PIE-2044

Verification

Integration testing using buildkite/buildkite

Renders failures correctly:

Does not render correctly:

Fails gracefully:

meghan-kradolfer commented 1 year ago

@niceking Those updates have been made and new specs added, would you be able to have another look please?

meghan-kradolfer commented 1 year ago

@niceking updates to those tests have been made. I also updated the description and added some checks for the integration testing I've done