search

buildkite / test-collector-ruby

Buildkite Test Analytics collector for Ruby test frameworks
http://buildkite.com/test-analytics
MIT License
15 stars 26 forks source link

Bump version to v2.3.3 #208

Closed meghan-kradolfer closed 10 months ago

meghan-kradolfer commented 10 months ago

What's changed:

niceking commented 10 months ago

Hey! This looks correct, but the Gemfile.lock is bumping up the version number of a lot of gems that aren't test collector ruby. Because we'll be including this gem in bk/bk, it'll then bump up the same gems over in that repository too, which might not be safe to do in production without some thorough testing, especially in core libraries like activesupport.

Could you please regenerate the Gemfile.lock with a smaller changeset? You should be able to check out the Gemfile.lock from main and then run bundle update buildkite-test_collector --conservative which will only update dependant libraries if they absolutely have to be updated

niceking commented 10 months ago

Also, we've changed to have bk/bk bundle test collector ruby directly from the github source, rather than a gem version, so you also don't have to do a release, you could just update the gem in bk/bk and check that the commit sha in the Gemfile.lock on bk/bk points to newest commit in this repo

meghan-kradolfer commented 10 months ago

Could you please regenerate the Gemfile.lock with a smaller changeset? You should be able to check out the Gemfile.lock from main and then run bundle update buildkite-test_collector --conservative which will only update dependant libraries if they absolutely have to be updated

Done!

meghan-kradolfer commented 10 months ago

I'm going to close this PR and make a new one to update to 2.4.0