buildkite / test-engine-client

Buildkite Test Engine Client (bktec) is an open source tool to orchestrate your test suites. It uses your Buildkite Test Engine suite data to intelligently partition and parallelise your tests.
MIT License
9 stars 1 forks source link

[TET-367] Fix path bug when using shared examples. #188

Closed wooly closed 2 months ago

wooly commented 2 months ago

Description

SBE is broken when shared examples are involved, because of the way we generate the Path field for each example.

Prior to this change, the file path and line number of the shared example would be used as the Path value, but this wont work because RSpec doesn't know which file to run the shared example for.

This change updates the Path field to use the identifier for the test instead.

niceking commented 2 months ago

Already merged but good catch 👍 I was just verifying this against the server side implementation. Would be good to do a release for this and test on bk^3