buildkite / test-engine-client

Buildkite Test Engine Client (bktec) is an open source tool to orchestrate your test suites. It uses your Buildkite Test Engine suite data to intelligently partition and parallelise your tests.
MIT License
9 stars 1 forks source link

Making test runner env mandatory #197

Closed amybiyuliu closed 2 months ago

amybiyuliu commented 2 months ago

Description

We made rspec as the default value of BUILDKITE_TEST_ENGINE_TEST_RUNNER as we didn't want to break older version of test splitter. As we also support jest now this default value no longer make sense. This PR makes BUILDKITE_TEST_ENGINE_TEST_RUNNER as a mandatory env.

Testing

When BUILDKITE_TEST_ENGINE_TEST_RUNNER is not set:

./test-engine-client Buildkite Test Engine: Invalid configuration... BUILDKITE_BUILD_ID must not be blank BUILDKITE_ORGANIZATION_SLUG must not be blank BUILDKITE_PARALLEL_JOB was "", must be a number BUILDKITE_PARALLEL_JOB_COUNT was "", must be a number BUILDKITE_STEP_ID must not be blank BUILDKITE_TEST_ENGINE_API_ACCESS_TOKEN must not be blank BUILDKITE_TEST_ENGINE_RESULT_PATH must not be blank BUILDKITE_TEST_ENGINE_SUITE_SLUG must not be blank BUILDKITE_TEST_ENGINE_TEST_RUNNER must not be blank