search

buildkite / test-engine-client

Buildkite Test Engine Client (bktec) is an open source tool to orchestrate your test suites. It uses your Buildkite Test Engine suite data to intelligently partition and parallelise your tests.
MIT License
9 stars 1 forks source link

Configure golangci-lint #199

Closed nprizal closed 1 month ago

nprizal commented 1 month ago

Configure golangci-lint for better linting. It has gosec support that is useful to catch security vulnerabilities. Followings are the issues caught by the configuration set in this PR.

internal/api/client.go:182:28: printf: non-constant format string in call to fmt.Errorf (govet)
            return resp, fmt.Errorf(errorResp.Message)
                                    ^
internal/config/config.go:45:15: Error return value of `c.readFromEnv` is not checked (errcheck)
    c.readFromEnv()
                 ^
internal/config/config.go:46:12: Error return value of `c.validate` is not checked (errcheck)
    c.validate()
              ^
internal/runner/command.go:42:23: Error return value of `cmd.Process.Signal` is not checked (errcheck)
                cmd.Process.Signal(sig)
                                  ^
internal/runner/discover.go:25:20: Error return value of `parsedPattern.Glob` is not checked (errcheck)
    parsedPattern.Glob(func(path string, d fs.DirEntry, err error) error {
                      ^
internal/runner/jest.go:161:16: unusedresult: result of slices.Replace call not used (govet)
    slices.Replace(words, outputIdx, outputIdx+1, j.ResultPath)
                  ^
internal/runner/jest.go:187:16: unusedresult: result of slices.Replace call not used (govet)
    slices.Replace(words, outputIdx, outputIdx+1, j.ResultPath)