search

buildkite / yaml2json

An easy to use command line tool to convert YAML to JSON
MIT License
12 stars 6 forks source link

Build both an Intel and ARM Mac binary #7

Closed ticky closed 3 years ago

ticky commented 3 years ago

Requires Go 1.16beta1, and turning GO111MODULE=off, but there's no CI for this project right now!

yob commented 3 years ago

Tested like this:

$ docker run -v `pwd`:/work -w /work -it golang:1.16beta1 bash

root@de9c2f61c727:/work# GO111MODULE=off ./scripts/build 
Building yaml2json 💨

Download Dependency
Compiling for Intel macOS
👍  dist/yaml2json-darwin-amd64

Compiling for ARM macOS
👍  dist/yaml2json-darwin-arm64

Compiling for Linux
👍  dist/yaml2json-linux-amd64

All done! ✅

Seems to work!

I guess GO111MODULE=off is required because this repo hasn't been initialised as a module yet? I reckon it's worth prefixing the three go build calls in script/build with GO111MODULE=off so future us doesn't need to remember to include it.

sj26 commented 3 years ago

there's no CI for this project right now

Sounds like a good time to add it :-)

ticky commented 3 years ago

I'm not entirely certain what to use as a best practice template here, terminal-to-html has some custom tooling but I'm not clear on whether that's the best approach. Anyone got opinions?

ticky commented 3 years ago

Okay, this adds CI which will exercise building, however, we're deferring configuring a release process for another time. Ready for review!