[Columns] Fix check for child as lazy node Column

buildo / bento-design-system

A customizable and extensible Design System framework for React.js projects

https://www.bento-ds.com

MIT License

107 stars 12 forks source link

[Columns] Fix check for child as lazy node Column #891

Closed pedrodim closed 3 weeks ago

pedrodim commented 3 weeks ago

Closes #835

Fix based on this comment. As the check now uses internals from a canary version of React any future updates to the payload format could break the check.

pedrodim commented 3 weeks ago

@gabro I made a bento build with the fix locally, replaced the updated build onto a Next.js project's node_modules and run the app 😄

<Columns space={16}>
  <Column>
    <Body size="small">Server A</Body>
  </Column>
  <Column width="3/5">
    <Body size="small">Server B</Body>
  </Column>
  <Column>
    <Body size="small">Server C</Body>
  </Column>
</Columns>

(client is the same but on a file with "use client")

Result: both server and client keep the width.

gabro commented 3 weeks ago

Good enough! Thanks