Add consistent-return

[ascariandrea]

requirements

Have a convention for returns.

specs

http://eslint.org/docs/rules/consistent-return

misc

@buildo/frontend thoughts?

[dhinus]

	repo	errors	warnings
❌	buildo/aliniq	9	0
❌	buildo/web-shared	2	0
❌	buildo/lexdoit	24	0
❌	buildo/ipercron	2	0
✅	buildo/bobafett	0	0
❌	contactlab/contacthub-sdk-browser	3	0
✅	contactlab/contacthub-sdk-nodejs	0	0
❌	buildo/avenger	1	0
❌	buildo/react-components	7	0
❌	buildo/rc-datepicker	2	0
❌	buildo/react-cookie-banner	2	0
❌	buildo/react-autosize-textarea	1	0
✅	buildo/react-input-link	0	0
✅	buildo/react-flexview	0	0
✅	buildo/react-placeholder	0	0
✅	buildo/local-date	0	0
✅	buildo/formo	0	0
❌	buildo/hophop	4	0
✅	buildo/nemobot	0	0
❌	buildo/prisma	4	0
❌	buildo/pledge	1	0

[gabro]

I know I'm aiming for the moon, but I think the most sensible way of dealing with the problem (provided we have it) is to use a static type checker and annotate the return type.

Also, having short functions helps.

That being said, this could be a temporary measure that helps, so if someone is willing to backport this on our code base, I'm 👍

[ascariandrea]

@gabro I would love to have a static type checker for our FE projects, but it needs a lot of effort :/

[gabro]

I know, it's just a consideration :) As I said, this rule is fine provided someone is willing to update our projects to conform to it