buildo / eslint-config

buildo's eslint shared config
http://buildo.io
4 stars 2 forks source link

Enfore space before '/>' in self-closing tags #113

Closed ecamellini closed 7 years ago

ecamellini commented 7 years ago

requirements

In case of self-closing tags (e.g., <MyComponent />) a space should always be present before the closing />.

Example: The following should be considered an error: <MyComponent/>

specs

{optional: describe technical specs to implement this feature, if not obvious}

misc

{optional: other useful info}

gabro commented 7 years ago

I agree with picking a rule for this, is there an existing rule that does it?

gabro commented 7 years ago

Some volunteer to run a linto report?

gabro commented 7 years ago

Detailed instructions here: https://github.com/buildo/eslint-config#proposing-a-new-rule

ecamellini commented 7 years ago

@gabro there is a rule, I already sent a PR but didn't run linto report. I can try to do it

gabro commented 7 years ago

Yes, please. If you have problems, let me know so that we can update the guide :)

ecamellini commented 7 years ago

@gabro I don't have the rights to access some of the repos. These are the results so far: image

veej commented 7 years ago
repo errors warnings
buildo/aliniq 77 0
buildo/web-shared 34 0
buildo/lexdoit 17 0
buildo/ipercron 6 0
buildo/bobafett 0 0
contactlab/contacthub-sdk-browser 0 0
contactlab/contacthub-sdk-nodejs 0 0
buildo/avenger 0 0
buildo/react-components 2 0
buildo/rc-datepicker 0 0
buildo/react-cookie-banner 0 0
buildo/react-autosize-textarea 0 0
buildo/react-input-link 0 0
buildo/react-flexview 0 0
buildo/react-placeholder 2 0
buildo/local-date 0 0
buildo/formo 3 0
buildo/hophop 0 0
buildo/nemobot 0 0
buildo/prisma 0 0
buildo/pledge 0 0
gabro commented 7 years ago

Thanks! It's also fixable, so maybe linto can fix all projects automagically 😇

giogonzo commented 7 years ago

Can someone remove web-shared? It's ☠

gabro commented 7 years ago

Oh, dead? I was fixing it :D

gabro commented 7 years ago

aaand it's gone (from linto-config)

gabro commented 7 years ago

If somebody wants to have the pleasure:

yarn global add linto
linto run --fix -n -c linto-config.yml

remove -n to actually open the pull requests

veej commented 7 years ago

oh, and since we're on the subject, could you add GDSM projects please? :P

gabro commented 7 years ago

Done!