search

buildo / eslint-config

buildo's eslint shared config
http://buildo.io
4 stars 2 forks source link

max-len should ignore URLs, strings and imports #74

Closed FrancescoCioria closed 8 years ago

FrancescoCioria commented 8 years ago

requirements

IMO max-len (to be finally more useful than annoying) should ignore URLs, strings and imports. http://eslint.org/docs/rules/max-len#ignoreurls

@buildo/frontend

specs

{optional: other useful info}

gabro commented 8 years ago

sounds good to me

gabro commented 8 years ago

not sure about imports, those can be easily split into multiple lines, if you're destructuring.

FrancescoCioria commented 8 years ago

Yes, we should probably remove the ugly regex for the imports

On Sep 14, 2016 13:39, "Gabriele Petronella" notifications@github.com wrote:

not sure about imports, those can be easily split into multiple lines, if you're destructuring.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/buildo/eslint-config/issues/74#issuecomment-246973338, or mute the thread https://github.com/notifications/unsubscribe-auth/AD18O60gZc_14P0Ud9qJe7jWJXvrK980ks5qp874gaJpZM4J8oHM .

FrancescoCioria commented 8 years ago

We reverted the PR due to a breaking change in "max-len" syntax that broke projects with eslint@2.

We should first upgrade every project that depends on this rules to eslint@3 and than re-merge the PR