buildo / eslint-config

buildo's eslint shared config
http://buildo.io
4 stars 2 forks source link

Evaluate eslint-plugin-compat #97

Open gabro opened 7 years ago

gabro commented 7 years ago

See https://github.com/amilajack/eslint-plugin-compat

gabro commented 7 years ago

Linto report

repo errors warnings
buildo/aliniq 0 0
buildo/web-shared 0 0
buildo/react-components 0 0
buildo/ipercron 0 0
buildo/avenger 3 0
buildo/bobafett 0 0
buildo/formo 0 0
buildo/hophop 0 0
buildo/pledge 0 0

The errors in avenger are about the use of fetch, which is not supported on Edge 13 and Safari 9.

giogonzo commented 7 years ago

No it is not using fetch, I think it's a false positive

FrancescoCioria commented 7 years ago

No it is not using fetch, I think it's a false positive

I remember it did, did you change it? I remember having to add a polyfill for IE11 due to fetch

gabro commented 7 years ago

If you run linto it now returns the snippet of where it's used and it did with Avenger. I'll double check

giogonzo commented 7 years ago

@gabro can't run it now from mobile; I think it's a false positive because the keyword fetch indeed appears multiple times in src, but not accessing the global fetch api https://github.com/buildo/avenger/search?utf8=%E2%9C%93&q=fetch

@FrancescoCioria common misconception, avenger lib itself is not interested in http or using any xhr api/library. If someone was requiring fetch, it must have been the project in e.g. api.js

gabro commented 7 years ago

Oh, yes then it probably matches the keyword, and it's a false positive. I'll try soon