search

buildo / metarpheus-io-ts

Generate domain models and client interpreting metarpheus output
MIT License
7 stars 1 forks source link

invalid API responses cause an uncaught Promise rejection instead of a proper TaskEither failure #107

Closed giogonzo closed 5 years ago

giogonzo commented 5 years ago

because of how the validation is implemented in https://github.com/buildo/metarpheus-io-ts/blob/master/src/index.ts#L433-L437

It should instead be a proper chain(fromEither())

Also the current AxiosError left type doesn't make much sense, I'd just stick to unknown for the moment