#107: invalid API responses cause an uncaught Promise rejection instead of a proper TaskEither failure (closes #107) - Githubissues

buildo / metarpheus-io-ts

Generate domain models and client interpreting metarpheus output

MIT License

7 stars 1 forks source link

#107: invalid API responses cause an uncaught Promise rejection instead of a proper TaskEither failure (closes #107) #108

Closed giogonzo closed 5 years ago

giogonzo commented 5 years ago

Closes #107

Test Plan

tests performed

tested on an internal project

before: UI loading forever + uncaught exception handling in console after: UI rendering error, no uncaught

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

nemobot commented 5 years ago