[TS] TimePicker searchable props type is out of sync - Githubissues

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

[TS] TimePicker searchable props type is out of sync #1019

Closed giogonzo closed 7 years ago

giogonzo commented 7 years ago

description

https://github.com/buildo/react-components/blob/master/src/TimePicker/TimePicker.d.ts#L19 is maybe, https://github.com/buildo/react-components/blob/master/src/TimePicker/TimePicker.js#L44 is not

how to reproduce

{optional: describe steps to reproduce defect}

specs

{optional: describe a possible fix for this defect, if not obvious}

misc

{optional: other useful info}

giogonzo commented 7 years ago

nevermind, there's a defaultProps in between. Still weird that it is not marked as optional in http://react-components.buildo.io/#/sections/components/component/time-picker?openSections=%3Bcomponents