#1029: ScrollView: scrollbars are visible even when thumb is hidden (closes #1029) - Githubissues

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

#1029: ScrollView: scrollbars are visible even when thumb is hidden (closes #1029) #1030

Closed FrancescoCioria closed 7 years ago

FrancescoCioria commented 7 years ago

Closes #1029

Test Plan

tests performed

tested on AlinityPRO:

scrollbars work as before
they're no longer visible/hoverable when thumb has height/width 0
if children use PureComponent (as we're doing) no useless render
- tested on UserPreferences page: same number of renders for UserRow

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

[ ]
[ ]

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

francescogior commented 7 years ago

@FrancescoCioria I rebased it on master

nemobot commented 7 years ago