buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1035: [Typo] Initial setup (closes #1035) #1039

Closed veej closed 7 years ago

veej commented 7 years ago

Closes #1035

Test Plan

tests performed

and all three keep working from #1041 branch! (so they work when src has one or more .tsx? files)

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

FrancescoCioria commented 7 years ago

@veej It finally works! the commit history is horrible, but who cares... in the end I made it work by making both typescript and babel transpile every file both in the build and in webpack... it's not a great solution, I know, but it works :P

UPDATE: ups, the tests are still failing...

ascariandrea commented 7 years ago

Shouldn't the lodash imports case be fixed also in package.json?

FrancescoCioria commented 7 years ago

Shouldn't the lodash imports case be fixed also in package.json?

what do you mean? they are correct in the package.json: they should all be in lowercase

ascariandrea commented 7 years ago

It's confusing the different case in import and dependencies in package.json. Won't the import fail for case sensitive os?

FrancescoCioria commented 7 years ago

It's confusing the different case in import and dependencies in package.json. Won't the import fail for case sensitive os?

can you make an example? I really don't understand: I fixed every case error of lodash and the CI (which is case sensitive) is passing. Which code are you reading?

ascariandrea commented 7 years ago

My bad 🙈 I was looking at the previous case instead the fixed one 😅

nemobot commented 7 years ago