search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1059: [Typo] ConfirmationInput (closes #1059) #1061

Closed veej closed 7 years ago

veej commented 7 years ago

Closes #1059

Test Plan

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

giogonzo commented 7 years ago

@gabro rationale? I get the idea, but does it actually make writing the component's internal simpler/cleaner? Otherwise is it just a matter of style (could add clarity I think)?

veej commented 7 years ago

@gabro better now?

nemobot commented 7 years ago