#1066: [Typo] Dropdown (closes #1066)

[giogonzo]

Closes #1066 Closes #1127

@veej @FrancescoCioria In the end I decided to keep using the (quite broken) react-select types, and didn't remove simpleValue handling (so that this PR is almost non-breaking, removing valueLink only) To be continued...

Test Plan

• tests are happy
• TS is happy on Alinity PRO (couldn't test the app yet, due to other BRC-TS issues)

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

• [ ]
• [ ]

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

[francescogior]

ping @veej for simpleValue

[veej]

simpleValue has default true, so we're using it everywhere we're not forcing it to false (and I'm not doing it on GDSM unless there is a real need, like in SuggestionInput). We chose this default to be backward compatible, so I suppose it's highly breaking.

[veej]

@FrancescoCioria I added few small changes and fixed tests (see last three commits). Changes to valueToOption are not relevant, since the function will be removed along with simpleValue prop. More important fixes are the Value definition and onChange type.

[nemobot]