Closed giogonzo closed 7 years ago
ping @veej for simpleValue
simpleValue
has default true
, so we're using it everywhere we're not forcing it to false
(and I'm not doing it on GDSM unless there is a real need, like in SuggestionInput
).
We chose this default to be backward compatible, so I suppose it's highly breaking.
@FrancescoCioria I added few small changes and fixed tests (see last three commits).
Changes to valueToOption
are not relevant, since the function will be removed along with simpleValue
prop.
More important fixes are the Value
definition and onChange
type.
Closes #1066 Closes #1127
@veej @FrancescoCioria In the end I decided to keep using the (quite broken) react-select types, and didn't remove simpleValue handling (so that this PR is almost non-breaking, removing valueLink only) To be continued...
Test Plan
tests performed
cross browser compatibility
tests not performed (domain coverage)