buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

[Menu] menuItemTemplate passes both `grow` and `shrink={false}` to FlexView #1120

Open gabro opened 7 years ago

gabro commented 7 years ago

Project card

description

menuItemTemplate passes both grow and shrink={false} to FlexView

This generates a warning from FlexView

passing both "grow" and "shrink={false}" is a no-op!;

how to reproduce

specs

TBD, but removing grow breaks in some cases. See: https://github.com/buildo/react-components/pull/1119#pullrequestreview-60369185

misc

{optional: other useful info}