search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

[Typo] TextOverflow popover.event type #1139

Closed giogonzo closed 7 years ago

giogonzo commented 7 years ago

← #1034

requirements

TooltipRequiredProps = {
  // ..
  /** popover props */
  popover: ObjectOverwrite<PopoverProps.Popover, {
    content: string,
    event?: undefined // <- this is causing some issues on Alinity PRO
  }>
  // ...

specs

use a more proper ObjectOmit

misc

{optional: other useful info}

FrancescoCioria commented 7 years ago

This should actually be fixed directly in alinity pro: the issue here is that the & in alinity pro is not correctly overwriting the prop event.

See the branch typo-brc in alinity pro for a possibile fix I made