search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

TimePicker should allow to "localize" am/pm #1141

Closed francescogior closed 7 years ago

francescogior commented 7 years ago

Closes #644

Test Plan

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

francescogior commented 7 years ago

So we had a timeFormatter prop already but it wasn't used?

no

nemobot commented 7 years ago