search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1083: Use TS namespaces for exported types (closes #1083) #1145

Closed FrancescoCioria closed 7 years ago

FrancescoCioria commented 7 years ago

Closes #1083

Test Plan

tests performed

TS is happy 🎉

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

FrancescoCioria commented 7 years ago

tsc --noEmit complains with these errors:

image

FrancescoCioria commented 7 years ago

tested on alinity-pro (branch typo-brc): everything works fine apart from two conflicting @types/react but this is probably due to the local npm i after the project's yarn.

nemobot commented 7 years ago